Repository navigation
Conversation
DOS accepts "NUL:", "CON:" and similar as device names. fdpp does not recognise them, so truename() rejects them on drives whose redirector declines the name, such as a CD-ROM served by MSCDEX. Recognise a trailing "NAME:" as a device name. Bare drive specifications such as "C:" are unchanged. Fixes the Big Red Racing installer, where COPYIT.BAT runs "md ... >nul:" with the CD-ROM as the current drive. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Author
|
OK this seems to be the better fix for the issues with the big red racing installer - it gets to the end and all the files are copied. It seems like having devices with a colon (e.g. NUL:) later in the paths wasn't working. In general not everything is exactly the same as MSDOS, but works enough - I could probably look at a follow up to bring things in line with what MSDOS returns. |
stsp
added a commit
to dosemu2/dosemu2
that referenced
this pull request
Oct 12, 2026
Member
|
I added #311 as a replacement, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOS accepts "NUL:", "CON:" and similar as device names. fdpp does not recognise them, so truename() rejects them on drives whose redirector declines the name, such as a CD-ROM served by MSCDEX.
Recognise a trailing "NAME:" as a device name. Bare drive specifications such as "C:" are unchanged.
Fixes the Big Red Racing installer, where COPYIT.BAT runs "md ... >nul:" with the CD-ROM as the current drive.